Skip to content

Conversation

lonitra
Copy link
Member

@lonitra lonitra commented Aug 13, 2024

Summary

Fixes dotnet/winforms#11845
Followed porting instructions in main issue

porting documentation for darkmode / async feature still pending

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Aug 13, 2024
@ghost ghost added the area-WinForms Issues or PRs that relate to WinForms. label Aug 13, 2024
@lonitra lonitra marked this pull request as draft August 13, 2024 18:05
Copy link

Learn Build status updates of commit 5c3c75e:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml ✅Succeeded View
xml/System.Windows.Forms/AccessibleEvents.xml ✅Succeeded View
xml/System.Windows.Forms/Application.xml ✅Succeeded View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml ✅Succeeded View
xml/System.Windows.Forms/ToolStrip.xml ✅Succeeded View
xml/System.Windows.Forms/ToolStripItem.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments.

@carlossanlop carlossanlop requested a review from gewarren August 16, 2024 21:34
Copy link

Learn Build status updates of commit 6fccd41:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml ✅Succeeded View
xml/System.Windows.Forms/AccessibleEvents.xml ✅Succeeded View
xml/System.Windows.Forms/Application.xml ✅Succeeded View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml ✅Succeeded View
xml/System.Windows.Forms/ToolStripItem.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link

Learn Build status updates of commit 9665cc6:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Forms.Design.Behavior/BehaviorServiceAdornerCollection.xml ✅Succeeded View
xml/System.Windows.Forms/AccessibleEvents.xml ✅Succeeded View
xml/System.Windows.Forms/Application.xml ✅Succeeded View
xml/System.Windows.Forms/GiveFeedbackEventArgs.xml ✅Succeeded View
xml/System.Windows.Forms/ToolStripItem.xml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@lonitra
Copy link
Member Author

lonitra commented Aug 27, 2024

@gewarren do we have an estimate for when the CI update for RC 1 will be? WinForms has some experimental apis that were introduced in RC1 so this is in draft to get those docs ported as well.

@gewarren
Copy link
Contributor

@gewarren do we have an estimate for when the CI update for RC 1 will be? WinForms has some apis that were introduced in RC1 so this is in draft to get those docs ported as well.

@lonitra It's usually a couple of days after it releases.

@carlossanlop
Copy link
Contributor

@lonitra so I assume you're going to wait for RC1 to be released before merging this?

@lonitra
Copy link
Member Author

lonitra commented Sep 5, 2024

so I assume you're going to wait for RC1 to be released before merging this?

Yes, we need the documentation for the experimental APIs as well to finish up documentation for net 9 so this will need to wait until the CI update.

Copy link

Learn Build status updates of commit 751cfe7:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
xml/System.Windows.Forms/ToolStrip.xml ❌Error Details

  • Line 0, Column 0: [Error: ECMA2Yaml_File_LoadFailed] Failed to load 1 files, aborting...

xml/System.Windows.Forms/ToolStrip.xml

  • Line 0, Column 0: [Error: ECMA2Yaml_InternalError]
Intenal Several Error: System.Xml.XmlException: The 'Members' start tag on line 117 position 4 does not match the end tag of 'Member'. Line 210, position 7.
   at System.Xml.XmlTextReaderImpl.Throw(Exception e)
   at System.Xml.XmlTextReaderImpl.Throw(String res, String[] args)
   at System.Xml.XmlTextReaderImpl.ThrowTagMismatch(NodeData startTag)
   at System.Xml.XmlTextReaderImpl.ParseEndElement()
   at System.Xml.XmlTextReaderImpl.ParseElementContent()
   at System.Xml.Linq.XContainer.ReadContentFrom(XmlReader r)
   at System.Xml.Linq.XDocument.Load(XmlReader reader, LoadOptions options)
   at System.Xml.Linq.XDocument.Parse(String text, LoadOptions options)
   at ECMA2Yaml.ECMALoader.LoadType(FileItem typeFile)
   at ECMA2Yaml.ECMALoader.LoadTypes(String basePath, Namespace ns)

For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Genevieve Warren <[email protected]>
@lonitra lonitra marked this pull request as ready for review September 19, 2024 20:38
Co-authored-by: Genevieve Warren <[email protected]>
@carlossanlop carlossanlop merged commit f69b3f0 into dotnet:main Sep 21, 2024
3 checks passed
@lonitra lonitra deleted the winformsdoc branch September 23, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-WinForms Issues or PRs that relate to WinForms. community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documenting .NET 9 APIs
4 participants